editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java - Issue 10384142: Initial support for 'Extract temp' - only when single expression selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java

Issue 10384142: Initial support for 'Extract temp' - only when single expression selected (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use ASTVisitor as type switch Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/ASTRewriteAnalyzer.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/META-INF/MANIFEST.MF » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java

index b0333b15a8732102bbd386ea39d85b4d25a15d96..ad49a25736c2763a96ea2fb61f76d4a80df7e94a 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/RewriteEventStore.java

@@ -17,6 +17,7 @@ import com.google.dart.compiler.ast.DartBlock;

import com.google.dart.compiler.ast.DartNode;

import com.google.dart.compiler.common.SourceInfo;

import com.google.dart.tools.core.DartCore;

+import com.google.dart.tools.core.dom.PropertyDescriptorHelper;

import com.google.dart.tools.core.dom.StructuralPropertyDescriptor;

import com.google.dart.tools.core.dom.rewrite.TargetSourceRangeComputer;

@@ -733,9 +734,7 @@ public final class RewriteEventStore {

if (nodePropertyMapper != null) {

return nodePropertyMapper.getOriginalValue(parent, childProperty);

}

- DartCore.notYetImplemented();

- // return parent.getStructuralProperty(childProperty);

- return null;

+ return PropertyDescriptorHelper.getStructuralProperty(parent, childProperty);

}

private void assertNoOverlap(ListRewriteEvent listEvent, int indexFirst, int indexLast,