Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chromeos/dbus/ibus/ibus_object.cc

Issue 10384141: Extends IBusObject. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/ibus/ibus_object.h ('k') | chromeos/dbus/ibus/ibus_object_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/ibus/ibus_object.cc
diff --git a/chromeos/dbus/ibus/ibus_object.cc b/chromeos/dbus/ibus/ibus_object.cc
index c6b97465f0a8fc8690a06f885794f9a71435318a..ebba2b3060f757f7e0a980b67231602ab42e92bd 100644
--- a/chromeos/dbus/ibus/ibus_object.cc
+++ b/chromeos/dbus/ibus/ibus_object.cc
@@ -5,9 +5,12 @@
#include "chromeos/dbus/ibus/ibus_object.h"
#include "base/logging.h"
+#include "chromeos/dbus/ibus/ibus_text.h"
#include "dbus/message.h"
namespace chromeos {
+// TODO(nona): Remove ibus namespace after complete libibus removal.
+namespace ibus {
///////////////////////////////////////////////////////////////////////////////
// IBusObjectReader
@@ -92,12 +95,37 @@ bool IBusObjectReader::PopUint32(uint32* out) {
return IsValid() && contents_reader_->PopUint32(out);
}
+bool IBusObjectReader::PopInt32(int32* out) {
+ DCHECK_NE(IBUS_OBJECT_NOT_CHECKED, check_result_);
+ DCHECK(contents_reader_.get());
+ return IsValid() && contents_reader_->PopInt32(out);
+}
+
+bool IBusObjectReader::PopBool(bool* out) {
+ DCHECK_NE(IBUS_OBJECT_NOT_CHECKED, check_result_);
+ DCHECK(contents_reader_.get());
+ return IsValid() && contents_reader_->PopBool(out);
+}
+
bool IBusObjectReader::PopArray(dbus::MessageReader* reader) {
DCHECK_NE(IBUS_OBJECT_NOT_CHECKED, check_result_);
DCHECK(contents_reader_.get());
return IsValid() && contents_reader_->PopArray(reader);
}
+bool IBusObjectReader::PopIBusText(IBusText* text) {
+ DCHECK_NE(IBUS_OBJECT_NOT_CHECKED, check_result_);
+ DCHECK(contents_reader_.get());
+ return IsValid() && chromeos::ibus::PopIBusText(contents_reader_.get(), text);
+}
+
+bool IBusObjectReader::PopStringFromIBusText(std::string* text) {
+ DCHECK_NE(IBUS_OBJECT_NOT_CHECKED, check_result_);
+ DCHECK(contents_reader_.get());
+ return IsValid() && chromeos::ibus::PopStringFromIBusText(
+ contents_reader_.get(), text);
+}
+
bool IBusObjectReader::HasMoreData() {
DCHECK_NE(IBUS_OBJECT_NOT_CHECKED, check_result_);
DCHECK(contents_reader_.get());
@@ -141,12 +169,32 @@ void IBusObjectWriter::AppendUint32(uint32 input) {
contents_writer_->AppendUint32(input);
}
+void IBusObjectWriter::AppendInt32(int32 input) {
+ DCHECK(IsInitialized());
+ contents_writer_->AppendInt32(input);
+}
+
+void IBusObjectWriter::AppendBool(bool input) {
+ DCHECK(IsInitialized());
+ contents_writer_->AppendBool(input);
+}
+
void IBusObjectWriter::OpenArray(const std::string& signature,
dbus::MessageWriter* writer) {
DCHECK(IsInitialized());
contents_writer_->OpenArray(signature, writer);
}
+void IBusObjectWriter::AppendIBusText(const IBusText& text) {
+ DCHECK(IsInitialized());
+ chromeos::ibus::AppendIBusText(text, contents_writer_.get());
+}
+
+void IBusObjectWriter::AppendStringAsIBusText(const std::string& text) {
+ DCHECK(IsInitialized());
+ chromeos::ibus::AppendStringAsIBusText(text, contents_writer_.get());
+}
+
void IBusObjectWriter::CloseContainer(dbus::MessageWriter* writer) {
DCHECK(IsInitialized());
contents_writer_->CloseContainer(writer);
@@ -198,4 +246,5 @@ bool IBusObjectWriter::IsInitialized() const {
return contents_writer_.get() != NULL;
}
+} // namespace ibus
} // namespace chromeos
« no previous file with comments | « chromeos/dbus/ibus/ibus_object.h ('k') | chromeos/dbus/ibus/ibus_object_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698