Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Issue 10384128: Quote WebPreferences in namespace webkit_glue. (Closed)

Created:
8 years, 7 months ago by Xianzhu
Modified:
8 years, 7 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, jam, yoshiki+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, tfarina
Visibility:
Public.

Description

Quote WebPreferences in namespace webkit_glue. To avoid name conflict when linking DumpRenderTree which has its own implementation of the class with the same name. BUG=127811 TEST=Build all without errors TBR=kalman@chromium.org,dpapad@chromium.org,ben@chromium.org,battre@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136707

Patch Set 1 #

Patch Set 2 : mac files #

Patch Set 3 : Copyright 2012 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -94 lines) Patch
M ash/shell/content_client/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content_client/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/test_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/test_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/public/browser/render_view_host.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/public/browser/render_view_host_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/public/browser/render_view_host_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_view.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 6 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_contents_tester.h View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_preferences.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppapi_preferences.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/examples/content_client/examples_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/plugins/webview_plugin.h View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/plugins/webview_plugin.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 2 4 chunks +8 lines, -26 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/webview_host.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webview_host_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webview_host_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Xianzhu
8 years, 7 months ago (2012-05-11 19:49:00 UTC) #1
tony
It would probably be easier to put the other WebPreferences in a namespace since it's ...
8 years, 7 months ago (2012-05-11 20:57:18 UTC) #2
Xianzhu
On 2012/05/11 20:57:18, tony wrote: > It would probably be easier to put the other ...
8 years, 7 months ago (2012-05-11 21:12:05 UTC) #3
tony
On 2012/05/11 21:12:05, Xianzhu wrote: > On 2012/05/11 20:57:18, tony wrote: > > It would ...
8 years, 7 months ago (2012-05-11 21:44:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10384128/4003
8 years, 7 months ago (2012-05-11 21:58:54 UTC) #5
commit-bot: I haz the power
Presubmit check for 10384128-4003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-11 21:59:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10384128/10001
8 years, 7 months ago (2012-05-11 22:09:52 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 23:31:28 UTC) #8
Change committed as 136707

Powered by Google App Engine
This is Rietveld 408576698