Chromoting: the Me2me host now presents a notification on the console allowing a user to disconnect…

remoting/host/disconnect_window_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "remoting/host/disconnect_window_mac.h"
 
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "remoting/host/chromoting_host.h"
 #include "remoting/host/disconnect_window.h"
 
 namespace remoting {
 
 class DisconnectWindowMac : public remoting::DisconnectWindow {
  public:
   DisconnectWindowMac();
   virtual ~DisconnectWindowMac();
 
-  virtual void Show(remoting::ChromotingHost* host,
+  virtual void Show(ChromotingHost* host,
+                    const DisconnectCallback& disconnect_callback,
                     const std::string& username) OVERRIDE;
   virtual void Hide() OVERRIDE;
 
  private:
   DisconnectWindowController* window_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(DisconnectWindowMac);
 };
 
 DisconnectWindowMac::DisconnectWindowMac()
     : window_controller_(nil) {
 }
 
 DisconnectWindowMac::~DisconnectWindowMac() {
   [window_controller_ close];
 }
 
-void DisconnectWindowMac::Show(remoting::ChromotingHost* host,
+void DisconnectWindowMac::Show(ChromotingHost* host,
+                               const DisconnectCallback& disconnect_callback,
                                const std::string& username) {
   CHECK(window_controller_ == nil);
   NSString* nsUsername = base::SysUTF8ToNSString(username);
   window_controller_ =
       [[DisconnectWindowController alloc] initWithHost:host
+                                              callback:disconnect_callback
                                               username:nsUsername];
   [window_controller_ showWindow:nil];
 }
 
 void DisconnectWindowMac::Hide() {
   // DisconnectWindowController is responsible for releasing itself in its
   // windowWillClose: method.
   [window_controller_ close];
   window_controller_ = nil;
 }
 
 scoped_ptr<DisconnectWindow> DisconnectWindow::Create() {
   return scoped_ptr<DisconnectWindow>(new DisconnectWindowMac());
 }
 
 }  // namespace remoting
 
 @interface DisconnectWindowController()
 @property (nonatomic, assign) remoting::ChromotingHost* host;
+@property (nonatomic, assign) DisconnectCallback disconnect_callback;

[dcaiafa, 2012/05/11 20:10:38]

This doesn't need to be a property. It's private and doesn't require special
actions on access. It looks like this is true for host and username as well, but
this can be fixed in a different CL. 

[alexeypa (please no reviews), 2012/05/11 20:19:29]

Removed.

 @property (nonatomic, copy) NSString* username;
 
 - (BOOL)isRToL;
 
 @end
 
 @implementation DisconnectWindowController
 
 @synthesize host = host_;
+@synthesize disconnect_callback = disconnect_callback_;

[dcaiafa, 2012/05/11 20:10:38]

Again, not needed.

[alexeypa (please no reviews), 2012/05/11 20:19:29]

Done.

 @synthesize username = username_;
 
 - (id)initWithHost:(remoting::ChromotingHost*)host
+          callback:(const DisconnectCallback&)disconnect_callback
           username:(NSString*)username {
   self = [super initWithWindowNibName:@"disconnect_window"];
   if (self) {
     host_ = host;
+    disconnect_callback_ = disconnect_callback;
     username_ = [username copy];
   }
   return self;
 }
 
 - (void)dealloc {
   [username_ release];
   [super dealloc];
 }
 
 - (IBAction)stopSharing:(id)sender {
-  if (self.host) {
-    self.host->Shutdown(base::Closure());
-    self.host = NULL;
+  if (!self.disconnect_callback.is_null()) {

[dcaiafa, 2012/05/11 20:10:38]

To access the field directly, just drop the 'self.'. E.g.:
if (disconnect_callback_.is_null()) ...

[alexeypa (please no reviews), 2012/05/11 20:19:29]

Done.

+    self.disconnect_callback.Run();
   }
 }
 
 - (BOOL)isRToL {
   if (host_) {
     return host_->ui_strings().direction == remoting::UiStrings::RTL;
   } else {
     return false;
   }
 }
@@ skipping 184 matching lines @@
   path = [NSBezierPath bezierPath];
   [path moveToPoint:top];
   [path lineToPoint:bottom];
   [light setStroke];
   [path stroke];
 
   [context setShouldAntialias:alias];
 }
 
 @end