Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10384092: Disable warning in leveldb (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Disable warning in leveldb Patch has been committed upstream (internal) but it will be a while before it's released to code.google.com, and then rolled into Chromium. So, disable minor warning for now. R=thakis@chromium.org BUG=126483 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137678

Patch Set 1 #

Patch Set 2 : add comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/leveldatabase/leveldatabase.gyp View 1 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
scottmg
oops, forgot to push 'm'.
8 years, 7 months ago (2012-05-17 16:32:52 UTC) #1
Nico
lgtm do windows folks know all these warning codes by hand? if not, maybe add ...
8 years, 7 months ago (2012-05-17 17:13:25 UTC) #2
scottmg
On 2012/05/17 17:13:25, Nico wrote: > lgtm > > do windows folks know all these ...
8 years, 7 months ago (2012-05-17 17:21:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10384092/4001
8 years, 7 months ago (2012-05-17 17:22:37 UTC) #4
Nico
thanks! https://chromiumcodereview.appspot.com/10384092/diff/4001/third_party/leveldatabase/leveldatabase.gyp File third_party/leveldatabase/leveldatabase.gyp (right): https://chromiumcodereview.appspot.com/10384092/diff/4001/third_party/leveldatabase/leveldatabase.gyp#newcode60 third_party/leveldatabase/leveldatabase.gyp:60: # Internal link: https://mondrian.corp.google.com/#review/29997992 nit: to not leak ...
8 years, 7 months ago (2012-05-17 17:24:45 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 17:25:38 UTC) #6
Try job failure for 10384092-4001 on win for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698