Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10384086: Moved url_utils from chrome/browser/net to chrome/common/net. (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16
Modified:
8 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, ajwong+watch_chromium.org, achuith+watch_chromium.org, Avi (use Gerrit), darin-cc_chromium.org, brettw-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Moved url_utils from chrome/browser/net to chrome/common/net. There is an upcoming CL that needs those functions from chrome/common/extensions. TBR=satorux@chromium.org, pkasting@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -289 lines) Patch
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_documents_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google/google_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/net/browser_url_util.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/net/browser_url_util.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/net/browser_url_util_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/notification_promo.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/common/net/url_util.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/common/net/url_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/net/url_util_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
Mostly tools/git/mass_rename.sh, tools/sort_headers.py. Manually fixed test names and namespaces
8 years, 7 months ago (2012-05-09 20:24:25 UTC) #1
James Hawkins
rubber-stamp LGTM
8 years, 7 months ago (2012-05-09 20:47:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10384086/1
8 years, 7 months ago (2012-05-09 20:49:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 10384086-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-09 20:49:34 UTC) #4
groby-ooo-7-16
TBR'd satorux for cros, pkasting for ui
8 years, 7 months ago (2012-05-09 20:58:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10384086/1
8 years, 7 months ago (2012-05-09 20:58:40 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 22:34:39 UTC) #7 
Change committed as 136154

Powered by Google App Engine
This is Rietveld 408576698