Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10384079: Reland "Implement random wallpaper feature" (Closed)

Created:
8 years, 7 months ago by bshe
Modified:
8 years, 7 months ago
Reviewers:
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reland "Implement random wallpaper feature" CL 10302016 reverted because of failed testes on linux chromeos bot. The reason was a DCHECK fail. I have fixed the fails in CL 10382072. So reland the random wallpaper feature here. TBR=nikita,ben,jhawkins BUG=120217 TEST=Go to set wallpaper overlay in settings page, check the "I'm feeling lucky" checkbox. Sign out and sign in a couple of times, verify if the wallpaper is random. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -77 lines) Patch
M ash/desktop_background/desktop_background_resources.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_resources.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 5 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 13 chunks +125 lines, -39 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/set_wallpaper_options.css View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/set_wallpaper_options.html View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/set_wallpaper_options.js View 3 chunks +37 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc View 4 chunks +26 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/10384079/1
8 years, 7 months ago (2012-05-09 15:16:22 UTC) #1
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 16:32:52 UTC) #2 
Change committed as 136044

Powered by Google App Engine
This is Rietveld 408576698