Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc

Issue 10384072: Update to handle absolute-looking paths in manifests and still produce nice-looking URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
index 1d7264d669817a0dee99e14c274a977d1e8115d9..59ca69cd988aabb1c5ffe3fb3c427616c3abbf37 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
@@ -73,7 +73,7 @@ TEST_F(ExtensionManifestTest, WebIntents) {
UTF16ToUTF8(extension->intents_services()[0].action));
EXPECT_EQ("chrome-extension",
extension->intents_services()[0].service_url.scheme());
- EXPECT_EQ("//services/share",
+ EXPECT_EQ("/services/share",
extension->intents_services()[0].service_url.path());
EXPECT_EQ("Sample Sharing Intent",
UTF16ToUTF8(extension->intents_services()[0].title));
@@ -96,7 +96,7 @@ TEST_F(ExtensionManifestTest, WebIntents) {
extension = LoadAndExpectSuccess("intent_valid_using_href.json");
ASSERT_TRUE(extension.get() != NULL);
ASSERT_EQ(1u, extension->intents_services().size());
- EXPECT_EQ("//services/share",
+ EXPECT_EQ("/services/share",
extension->intents_services()[0].service_url.path());
}
@@ -114,7 +114,7 @@ TEST_F(ExtensionManifestTest, WebIntentsWithMultipleMimeTypes) {
UTF16ToUTF8(extension->intents_services()[i].action));
EXPECT_EQ("chrome-extension",
extension->intents_services()[i].service_url.scheme());
- EXPECT_EQ("//services/share",
+ EXPECT_EQ("/services/share",
extension->intents_services()[i].service_url.path());
EXPECT_EQ("Sample Sharing Intent",
UTF16ToUTF8(extension->intents_services()[i].title));
@@ -164,11 +164,11 @@ TEST_F(ExtensionManifestTest, WebIntentsMultiHref) {
extension->intents_services();
EXPECT_EQ("chrome-extension", intents[0].service_url.scheme());
- EXPECT_EQ("//services/sharelink.html",intents[0].service_url.path());
+ EXPECT_EQ("/services/sharelink.html",intents[0].service_url.path());
EXPECT_EQ("text/uri-list",UTF16ToUTF8(intents[0].type));
EXPECT_EQ("chrome-extension", intents[1].service_url.scheme());
- EXPECT_EQ("//services/shareimage.html",intents[1].service_url.path());
+ EXPECT_EQ("/services/shareimage.html",intents[1].service_url.path());
EXPECT_EQ("image/*",UTF16ToUTF8(intents[1].type));
}
« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698