Issue 10384072: Update to handle absolute-looking paths in manifests and still produce nice-looking URLs.

Issue 10384072: Update to handle absolute-looking paths in manifests and still produce nice-looking URLs. (Closed)

Created:
8 years, 7 months ago by Greg Billock

Modified:
8 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update to handle absolute-looking paths in manifests and still produce nice-looking URLs. R=aa@chromium.org BUG=127316 TEST=ExtensionTest.GetResourceURLAndPath,WebIntentsRegistryTest.GetIntentServicesForExtensionFilter Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137169

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Patch Set 3 : Fix paths in other tests. #

Patch Set 4 : Merge to head #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
M	chrome/browser/intents/web_intents_registry_unittest.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc	View	1 2	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

LGTM w/ nits. No need to wait for another review from me. http://codereview.chromium.org/10384072/diff/1/chrome/browser/intents/web_intents_registry_unittest.cc File chrome/browser/intents/web_intents_registry_unittest.cc ...

8 years, 7 months ago (2012-05-10 16:49:08 UTC) #2

Greg Billock

http://codereview.chromium.org/10384072/diff/1/chrome/browser/intents/web_intents_registry_unittest.cc File chrome/browser/intents/web_intents_registry_unittest.cc (right): http://codereview.chromium.org/10384072/diff/1/chrome/browser/intents/web_intents_registry_unittest.cc#newcode11 chrome/browser/intents/web_intents_registry_unittest.cc:11: #include "base/stringprintf.h" On 2012/05/10 16:49:08, Aaron Boodman wrote: > ...

8 years, 7 months ago (2012-05-14 16:09:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10384072/8003

8 years, 7 months ago (2012-05-14 23:51:34 UTC) #4

commit-bot: I haz the power

8 years, 7 months ago (2012-05-15 08:32:56 UTC) #5

Try job failure for 10384072-8003 (retry) on linux_rel for step "browser_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages