Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: chrome/browser/ui/views/notifications/balloon_view.cc

Issue 10384068: views: Have a more accurate name for View parent_owned accessors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/notifications/balloon_view.h" 5 #include "chrome/browser/ui/views/notifications/balloon_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 html_container_(NULL), 105 html_container_(NULL),
106 html_contents_(NULL), 106 html_contents_(NULL),
107 method_factory_(this), 107 method_factory_(this),
108 close_button_(NULL), 108 close_button_(NULL),
109 animation_(NULL), 109 animation_(NULL),
110 options_menu_model_(NULL), 110 options_menu_model_(NULL),
111 options_menu_button_(NULL), 111 options_menu_button_(NULL),
112 enable_web_ui_(false) { 112 enable_web_ui_(false) {
113 // This object is not to be deleted by the views hierarchy, 113 // This object is not to be deleted by the views hierarchy,
114 // as it is owned by the balloon. 114 // as it is owned by the balloon.
115 set_parent_owned(false); 115 set_owned_by_client();
116 116
117 views::BubbleBorder* bubble_border = 117 views::BubbleBorder* bubble_border =
118 new views::BubbleBorder(views::BubbleBorder::FLOAT, 118 new views::BubbleBorder(views::BubbleBorder::FLOAT,
119 views::BubbleBorder::NO_SHADOW); 119 views::BubbleBorder::NO_SHADOW);
120 set_border(bubble_border); 120 set_border(bubble_border);
121 } 121 }
122 122
123 BalloonViewImpl::~BalloonViewImpl() { 123 BalloonViewImpl::~BalloonViewImpl() {
124 } 124 }
125 125
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 return; 539 return;
540 } 540 }
541 541
542 // If the renderer process attached to this balloon is disconnected 542 // If the renderer process attached to this balloon is disconnected
543 // (e.g., because of a crash), we want to close the balloon. 543 // (e.g., because of a crash), we want to close the balloon.
544 notification_registrar_.Remove( 544 notification_registrar_.Remove(
545 this, chrome::NOTIFICATION_NOTIFY_BALLOON_DISCONNECTED, 545 this, chrome::NOTIFICATION_NOTIFY_BALLOON_DISCONNECTED,
546 content::Source<Balloon>(balloon_)); 546 content::Source<Balloon>(balloon_));
547 Close(false); 547 Close(false);
548 } 548 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.cc ('k') | chrome/browser/ui/views/tabs/dragged_tab_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698