Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 10384051: mac: Build third-party code with -Werror too. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Build third-party code with -Werror too. If third-party code does trigger warnings, they should be disabled in that third-party module's gyp file instead, or if they are serious, fixed. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
8 years, 7 months ago (2012-05-08 00:07:41 UTC) #1
Avi (use Gerrit)
+1
8 years, 7 months ago (2012-05-08 00:10:37 UTC) #2
Mark Mentovai
I guess the bot coverage is good enough now that other-platform people will still have ...
8 years, 7 months ago (2012-05-08 15:31:38 UTC) #3
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-08 15:31:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10384051/1
8 years, 7 months ago (2012-05-08 15:36:07 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 17:26:47 UTC) #6
Try job failure for 10384051-1 (retry) on win_rel for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698