Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/common/json_pref_store.h

Issue 10384047: Revert 135222 - it broke multiprofile tests - Use worker pool for IO in JsonPrefStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/important_file_writer.cc ('k') | chrome/common/json_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/json_pref_store.h
===================================================================
--- chrome/common/json_pref_store.h (revision 135722)
+++ chrome/common/json_pref_store.h (working copy)
@@ -19,7 +19,7 @@
namespace base {
class DictionaryValue;
-class SequencedTaskRunner;
+class MessageLoopProxy;
class Value;
}
@@ -29,10 +29,10 @@
class JsonPrefStore : public PersistentPrefStore,
public ImportantFileWriter::DataSerializer {
public:
- // |blocking_task_runner| is the SequencedTaskRunner on which file
- // I/O can be done.
+ // |file_message_loop_proxy| is the MessageLoopProxy for a thread on which
+ // file I/O can be done.
JsonPrefStore(const FilePath& pref_filename,
- base::SequencedTaskRunner* blocking_task_runner);
+ base::MessageLoopProxy* file_message_loop_proxy);
// PrefStore overrides:
virtual ReadResult GetValue(const std::string& key,
@@ -70,7 +70,7 @@
virtual bool SerializeData(std::string* output) OVERRIDE;
FilePath path_;
- scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_;
scoped_ptr<base::DictionaryValue> prefs_;
« no previous file with comments | « chrome/common/important_file_writer.cc ('k') | chrome/common/json_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698