chrome/browser/ui/views/omnibox/omnibox_view_win.cc - Issue 10384007: First stab at touch optimized omnibox auto-complete per sgabriel's mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

Issue 10384007: First stab at touch optimized omnibox auto-complete per sgabriel's mocks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

index b68b2751e42c5a739161ff7e3b0cc3fe24d888ad..17ad8af091b8842c6eeb7867ae14670ba6543543 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

@@ -437,9 +437,8 @@ OmniboxViewWin::OmniboxViewWin(AutocompleteEditController* controller,

views::View* location_bar)

: model_(new AutocompleteEditModel(this, controller,

parent_view->profile())),

- popup_view_(new AutocompletePopupContentsView(parent_view->font(), this,

- model_.get(),

- location_bar)),

+ popup_view_(AutocompletePopupContentsView::CreateForEnvironment(

+ parent_view->font(), this, model_.get(), location_bar)),

controller_(controller),

parent_view_(parent_view),

toolbar_model_(toolbar_model),

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | no next file » | no next file with comments »