Issue 10383303: Gracefully deal with clearing content settings for unregistered extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383303: Gracefully deal with clearing content settings for unregistered extensions. (Closed)

Created:
8 years, 7 months ago by Bernhard Bauer

Modified:
8 years, 6 months ago

Reviewers:
battre

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Gracefully deal with clearing content settings for unregistered extensions. This CL is only for merging to the M20 branch; on trunk I'm going to revert it and add additional information to the crash dumps to find out why this is happening. BUG=128652 TEST=no crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141415

Patch Set 1 #

Patch Set 2 : fix #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	chrome/browser/extensions/api/content_settings/content_settings_store.cc	View	1	2 chunks	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10383303/1

8 years, 6 months ago (2012-06-11 13:50:17 UTC) #3

commit-bot: I haz the power

Try job failure for 10383303-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...

8 years, 6 months ago (2012-06-11 14:10:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10383303/13002

8 years, 6 months ago (2012-06-11 14:14:57 UTC) #5

Change committed as 141415

Expand Messages | Collapse Messages