lib/dom/templates/dom/native/dart_implementation.darttemplate - Issue 10383302: Move dart:dom implementation classes to dart:html library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/templates/dom/native/dart_implementation.darttemplate

Issue 10383302: Move dart:dom implementation classes to dart:html library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/dom/src/native_DOMWrapperBase.dart ('K') | « lib/dom/templates/dom/native/cpp_implementation.template ('k') | lib/dom/templates/html/dartium/factoryprovider.darttemplate » ('j') | lib/dom/templates/html/dartium/factoryprovider_CSSMatrix.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/dom/templates/dom/native/dart_implementation.darttemplate

diff --git a/lib/dom/templates/dom/native/dart_implementation.darttemplate b/lib/dom/templates/dom/native/dart_implementation.darttemplate

index 62a255d3aa76870c4dc3865c7b97f4f14b1473d7..c4422b49aa7418965509bcdab0d8df0e105f93ca 100644

--- a/lib/dom/templates/dom/native/dart_implementation.darttemplate

+++ b/lib/dom/templates/dom/native/dart_implementation.darttemplate

@@ -4,9 +4,15 @@

// WARNING: Do not edit - generated code.

-class $CLASS extends $BASE implements $INTERFACE {

- static $CLASS _create$CLASS() => new $CLASS._create$CLASS();

+interface _$INTERFACE {

+class $CLASS extends $BASE implements _$INTERFACE {

$CLASS._create$CLASS();

String get typeName() => "$INTERFACE";

$MEMBERS

}

+_create$CLASS() => new $CLASS._create$CLASS();

Anton Muhin 2012/05/23 14:03:31 why those are not static methods?

podivilov 2012/05/23 14:52:40 Because of the bug with Dart_GetClass for private

+_is$CLASS(object) => object is $CLASS;