Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 10383299: Merge 117645 - [chromium] add back-face visibility check for renderSurfaces (Closed)

Created:
8 years, 7 months ago by shawnsingh
Modified:
8 years, 7 months ago
Reviewers:
shawnsingh
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 117645 - [chromium] add back-face visibility check for renderSurfaces https://bugs.webkit.org/show_bug.cgi?id=86870 Reviewed by Adrienne Walker. Source/WebCore: Test added CCLayerTreeHostCommonTest::verifyBackFaceCullingWithPreserves3dForFlatteningSurface Chromium was not checking back-face visibility for renderSurfaces that needed it. This patch adds that check and the appropriate unit test. * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: (WebCore::layerIsInExisting3DRenderingContext): (WebCore): (WebCore::subtreeShouldRenderToSeparateSurface): (WebCore::calculateDrawTransformsAndVisibilityInternal): Source/WebKit/chromium: * tests/CCLayerTreeHostCommonTest.cpp: (WebKitTests::TEST): (WebKitTests): TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp View 3 chunks +17 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
shawnsingh
8 years, 7 months ago (2012-05-23 04:30:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698