Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: content/common/url_schemes.cc

Issue 10383298: Move RegisterContentSchemes from public url_constants into non-public url_schemes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: take RegisterContentSchemes out of public Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/common/url_schemes.h"
6
7 #include <string.h>
8
9 #include <algorithm>
10 #include <string>
11 #include <vector>
12
13 #include "base/basictypes.h"
14 #include "base/string_util.h"
15 #include "content/public/common/content_client.h"
16 #include "content/public/common/url_constants.h"
17 #include "googleurl/src/url_util.h"
18
19 namespace {
20
21 void AddStandardSchemeHelper(const std::string& scheme) {
22 url_util::AddStandardScheme(scheme.c_str());
23 }
24
25 } // namespace
26
27 namespace content {
28
29 void RegisterContentSchemes(bool lock_standard_schemes) {
30 std::vector<std::string> additional_standard_schemes;
31 std::vector<std::string> additional_savable_schemes;
32 GetContentClient()->AddAdditionalSchemes(
33 &additional_standard_schemes,
34 &additional_savable_schemes);
35
36 // Don't need "chrome-internal" which was used in old versions of Chrome for
37 // the new tab page.
38 url_util::AddStandardScheme(chrome::kChromeDevToolsScheme);
39 url_util::AddStandardScheme(chrome::kChromeUIScheme);
40 url_util::AddStandardScheme(chrome::kMetadataScheme);
41 std::for_each(additional_standard_schemes.begin(),
42 additional_standard_schemes.end(),
43 AddStandardSchemeHelper);
44
45 // Prevent future modification of the standard schemes list. This is to
46 // prevent accidental creation of data races in the program. AddStandardScheme
47 // isn't threadsafe so must be called when GURL isn't used on any other
48 // thread. This is really easy to mess up, so we say that all calls to
49 // AddStandardScheme in Chrome must be inside this function.
50 if (lock_standard_schemes)
51 url_util::LockStandardSchemes();
52
53 // We rely on the above lock to protect this part from being invoked twice.
54 if (!additional_savable_schemes.empty()) {
55 const char* const* default_schemes = GetSavableSchemes();
56 const char* const* default_schemes_end = NULL;
57 for (default_schemes_end = default_schemes; *default_schemes_end++; ) {}
58 const int default_schemes_count = default_schemes_end - default_schemes;
59
60 int schemes = static_cast<int>(additional_savable_schemes.size());
61 // The array, and the copied schemes won't be freed, but will remain
62 // reachable.
63 char **savable_schemes = new char*[schemes + default_schemes_count];
64 memcpy(savable_schemes,
65 default_schemes,
66 (default_schemes_count - 1) * sizeof(default_schemes[0]));
67 for (int i = 0; i < schemes; ++i) {
68 savable_schemes[default_schemes_count + i - 1] =
69 base::strdup(additional_savable_schemes[i].c_str());
70 }
71 savable_schemes[default_schemes_count + schemes - 1] = 0;
72 SetSavableSchemes(savable_schemes);
73 }
74 }
75
76 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698