Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: webkit/fileapi/file_writer_delegate_unittest.cc

Issue 10383295: Disable FileWriterDelegateTest.WriteSuccessWithoutQuotaLimitConcurrent, which has been flaky on Win… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit) 5 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit)
6 // rather than as part of test_shell_tests because they rely on being able 6 // rather than as part of test_shell_tests because they rely on being able
7 // to instantiate a MessageLoop of type TYPE_IO. test_shell_tests uses 7 // to instantiate a MessageLoop of type TYPE_IO. test_shell_tests uses
8 // TYPE_UI, which URLRequest doesn't allow. 8 // TYPE_UI, which URLRequest doesn't allow.
9 // 9 //
10 10
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 file_writer_delegate_.reset(); 294 file_writer_delegate_.reset();
295 295
296 ASSERT_EQ(kAllowedGrowth, test_helper_.GetCachedOriginUsage()); 296 ASSERT_EQ(kAllowedGrowth, test_helper_.GetCachedOriginUsage());
297 EXPECT_EQ(ComputeCurrentOriginUsage(), test_helper_.GetCachedOriginUsage()); 297 EXPECT_EQ(ComputeCurrentOriginUsage(), test_helper_.GetCachedOriginUsage());
298 298
299 EXPECT_EQ(kAllowedGrowth, result_->bytes_written()); 299 EXPECT_EQ(kAllowedGrowth, result_->bytes_written());
300 EXPECT_EQ(base::PLATFORM_FILE_OK, result_->status()); 300 EXPECT_EQ(base::PLATFORM_FILE_OK, result_->status());
301 EXPECT_TRUE(result_->complete()); 301 EXPECT_TRUE(result_->complete());
302 } 302 }
303 303
304 TEST_F(FileWriterDelegateTest, WriteSuccessWithoutQuotaLimitConcurrent) { 304 #if defined(OS_WIN)
305 // See http://crbug.com/129264
306 #define MAYBE_WriteSuccessWithoutQuotaLimitConcurrent \
307 DISABLED_WriteSuccessWithoutQuotaLimitConcurrent
308 #else
309 #define MAYBE_WriteSuccessWithoutQuotaLimitConcurrent \
310 WriteSuccessWithoutQuotaLimitConcurrent
311 #endif
312
313 TEST_F(FileWriterDelegateTest, MAYBE_WriteSuccessWithoutQuotaLimitConcurrent) {
305 scoped_ptr<FileWriterDelegate> file_writer_delegate2; 314 scoped_ptr<FileWriterDelegate> file_writer_delegate2;
306 scoped_ptr<net::URLRequest> request2; 315 scoped_ptr<net::URLRequest> request2;
307 scoped_ptr<Result> result2; 316 scoped_ptr<Result> result2;
308 317
309 scoped_ptr<FileSystemOperationContext> context( 318 scoped_ptr<FileSystemOperationContext> context(
310 test_helper_.NewOperationContext()); 319 test_helper_.NewOperationContext());
311 bool created = false; 320 bool created = false;
312 file_util()->EnsureFileExists(context.get(), 321 file_util()->EnsureFileExists(context.get(),
313 GetFileSystemPath("test2"), 322 GetFileSystemPath("test2"),
314 &created); 323 &created);
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 file_writer_delegate_.reset(); 435 file_writer_delegate_.reset();
427 436
428 EXPECT_EQ(pre_write_usage + allowed_growth, 437 EXPECT_EQ(pre_write_usage + allowed_growth,
429 test_helper_.GetCachedOriginUsage()); 438 test_helper_.GetCachedOriginUsage());
430 EXPECT_EQ(ComputeCurrentOriginUsage(), test_helper_.GetCachedOriginUsage()); 439 EXPECT_EQ(ComputeCurrentOriginUsage(), test_helper_.GetCachedOriginUsage());
431 EXPECT_EQ(kOverlap + allowed_growth, result_->bytes_written()); 440 EXPECT_EQ(kOverlap + allowed_growth, result_->bytes_written());
432 EXPECT_EQ(base::PLATFORM_FILE_ERROR_NO_SPACE, result_->status()); 441 EXPECT_EQ(base::PLATFORM_FILE_ERROR_NO_SPACE, result_->status());
433 } 442 }
434 443
435 } // namespace fileapi 444 } // namespace fileapi
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698