Issue 10383278: Fix two call to masm->CallStub on x64: should pass ASTId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383278: Fix two call to masm->CallStub on x64: should pass ASTId. (Closed)

Created:
8 years, 7 months ago by Zheng Liu

Modified:
8 years, 7 months ago

Reviewers:
Sven Panne, rossberg, Michael Starzinger

CC:
v8-dev, zheng.z.liu

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix two call to masm->CallStub on x64: should pass ASTId. Committed: https://code.google.com/p/v8/source/detail?r=11628

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/x64/full-codegen-x64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Zheng Liu

Could you please review this patch? Thanks. Zheng Liu zheng.z.liu@intel.com

8 years, 7 months ago (2012-05-22 10:28:05 UTC) #1

Zheng Liu

v8/RayTrace improves ~12% on my machine(i7-860, Nahalem 2.8G). Likely because that some type-feedback was unused ...

8 years, 7 months ago (2012-05-23 04:45:13 UTC) #2

Sven Panne

LGTM. Good catch! I'll land for you when the test suite finishes..

8 years, 7 months ago (2012-05-23 06:56:29 UTC) #3

Sven Panne

8 years, 7 months ago (2012-05-23 08:57:28 UTC) #4

On 2012/05/23 06:56:29, Sven Panne wrote:
> LGTM. Good catch! I'll land for you when the test suite finishes..

Landed. I forgot to add the commit flag declaring you as the author though,
sorry... :-(

Expand Messages | Collapse Messages