Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4214)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/win/scoped_handle.h

Issue 10383276: Base: Crash when failing to close an scoped handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_handle.h
===================================================================
--- base/win/scoped_handle.h (revision 138198)
+++ base/win/scoped_handle.h (working copy)
@@ -74,7 +74,7 @@
void Close() {
if (Traits::IsHandleValid(handle_)) {
if (!Traits::CloseHandle(handle_)) {
- NOTREACHED();
+ CHECK(false);
}
handle_ = Traits::NullHandle();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698