Issue 10383276: Base: Crash when failing to close an scoped handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383276: Base: Crash when failing to close an scoped handle. (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)

Modified:
8 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Base: Crash when failing to close an scoped handle. BUG=127931 TEST=none TBR=willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138199

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/win/scoped_handle.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

8 years, 7 months ago (2012-05-22 02:28:15 UTC) #2

lgtm

On Mon, May 21, 2012 at 7:27 PM, <rvargas@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Base: Crash when failing to close an scoped handle.
>
> BUG=127931
> TEST=none
> TBR=willchan
>
> Please review this at
https://chromiumcodereview.**appspot.com/10383276/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     base/win/scoped_handle.h
>
>
> Index: base/win/scoped_handle.h
> ==============================**==============================**=======
> --- base/win/scoped_handle.h    (revision 138198)
> +++ base/win/scoped_handle.h    (working copy)
> @@ -74,7 +74,7 @@
>   void Close() {
>     if (Traits::IsHandleValid(handle_**)) {
>       if (!Traits::CloseHandle(handle_)**) {
> -        NOTREACHED();
> +        CHECK(false);
>       }
>       handle_ = Traits::NullHandle();
>     }
>
>
>

Expand Messages | Collapse Messages