Make AssociateWithRenderView() a free function in the 'content' namespace

Make AssociateWithRenderView() a free function in the 'content' namespace

Rename it to AssociateURLFetcherWithRenderView().

This will enable us to remove content::URLFetcher completely and use
net::URLFetcher exclusively.

BUG=118220
TEST=
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138178

[akalin, 2012-05-21 18:24:02]

+wtc for net stuff
+jam for content stuff

[jam, 2012-05-21 21:39:19]

lgtm

http://codereview.chromium.org/10383271/diff/13/content/public/common/url_fet...
File content/public/common/url_fetcher.h (right):

http://codereview.chromium.org/10383271/diff/13/content/public/common/url_fet...
content/public/common/url_fetcher.h:51: void CONTENT_EXPORT
AssociateWithRenderView(
nit: convention is CONTENT_EXPORT void

since this is now outside a class, make the static function's name clearer. i.e.
AssociateURLFetcherWithRenderView

[wtc, 2012-05-21 22:16:48]

Patch set 3 LGTM.  I only have some nit-picking comments
about the documentation of the new methods in
net/url_request/url_fetcher.h.  I know they are preexisting
problems because you merely copied the methods from another
file.  It would be nice to take the opportunity to improve
their documentation.

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h
File net/url_request/url_fetcher.h (right):

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h...
net/url_request/url_fetcher.h:81: // Data* object every time it's called.
Nit: perhaps remove the '*' after "Data"?  "Data*" implies a
pointer rather than an object.

It would be clearer to fully qualify base::SupportsUserData::Data.

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h...
net/url_request/url_fetcher.h:134: virtual void SetFirstPartyForCookies(

Can you copy the comment (or add it) for this method?

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h...
net/url_request/url_fetcher.h:137: // Whenever a URLRequest object is created,
SetUserData() will be

Is SetUserData a typo?  This method is named SetURLRequestUserData.
Ah, I think I see what you mean.  This comment is a little
confusing.  I think we should add a one-sentence description
of what SetURLRequestUserData does.

[akalin, 2012-05-21 22:28:36]

committing after trybots

http://codereview.chromium.org/10383271/diff/13/content/public/common/url_fet...
File content/public/common/url_fetcher.h (right):

http://codereview.chromium.org/10383271/diff/13/content/public/common/url_fet...
content/public/common/url_fetcher.h:51: void CONTENT_EXPORT
AssociateWithRenderView(
On 2012/05/21 21:39:19, John Abd-El-Malek wrote:
> nit: convention is CONTENT_EXPORT void
> 
> since this is now outside a class, make the static function's name clearer.
i.e.
> AssociateURLFetcherWithRenderView

Done.

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h
File net/url_request/url_fetcher.h (right):

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h...
net/url_request/url_fetcher.h:81: // Data* object every time it's called.
On 2012/05/21 22:16:48, wtc wrote:
> Nit: perhaps remove the '*' after "Data"?  "Data*" implies a
> pointer rather than an object.
> 
> It would be clearer to fully qualify base::SupportsUserData::Data.

Done.

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h...
net/url_request/url_fetcher.h:134: virtual void SetFirstPartyForCookies(
On 2012/05/21 22:16:48, wtc wrote:
> 
> Can you copy the comment (or add it) for this method?

Done.  Also updated URLFetcherCore docs.

http://codereview.chromium.org/10383271/diff/13/net/url_request/url_fetcher.h...
net/url_request/url_fetcher.h:137: // Whenever a URLRequest object is created,
SetUserData() will be
On 2012/05/21 22:16:48, wtc wrote:
> 
> Is SetUserData a typo?  This method is named SetURLRequestUserData.
> Ah, I think I see what you mean.  This comment is a little
> confusing.  I think we should add a one-sentence description
> of what SetURLRequestUserData does.

This *is* supposed to be the one-sentence description, but apparently it's not
clear.  Rewrote it to hopefully be clearer.

[commit-bot: I haz the power, 2012-05-21 22:40:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10383271/5014

[commit-bot: I haz the power, 2012-05-21 22:40:36]

Presubmit check for 10383271-5014 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/search_engines

Presubmit checks took 1.9s to calculate.

[akalin, 2012-05-21 22:47:42]

TBRing sky@ for search_engines

[commit-bot: I haz the power, 2012-05-21 23:08:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10383271/5014