Add the target ABI option for apk based test runner

Add the target ABI option for apk based test runner

Remove the hardcode directory name 'armeabi' and replace it with the Android target ABI information.

Trivial gyp changes that are android-specific; TBRing some owners
TBR=mark@chromium.org,jam@chromium.org,sky@chromium.org 

BUG=128944
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139512

[yongsheng, 2012-05-25 01:23:08]

Anyone who can help review or help forward to reviewers? Thanks a lot

[John Grabowski, 2012-05-25 16:42:46]

On 2012/05/25 01:23:08, yongsheng.zhu wrote:
> Anyone who can help review or help forward to reviewers? Thanks a lot

LGTM

We have a general agreement to TBR for *simple* gyp changes.  I believe this
qualifies.  Add this line to description:

Trivial gyp changes that are android-specific; TBRing some owners
TBR=mark@chromium.org,jam@chromium.org,sky@chromium.org 

Then I will click the commit box for you.

[Mark Mentovai, 2012-05-25 16:44:59]

LGTM for base OWNERS approval.

[nilesh, 2012-05-25 20:38:22]

http://codereview.chromium.org/10383263/diff/1/base/base.gyp
File base/base.gyp (right):

http://codereview.chromium.org/10383263/diff/1/base/base.gyp#newcode688
base/base.gyp:688: '--app_abi',
Please merge with http://codereview.chromium.org/10399126/.
This has moved into a template and we have more apk targets now. Not you only
need to add this to the template.

[nilesh, 2012-05-25 20:39:05]

On 2012/05/25 20:38:22, nileshagrawal1 wrote:
> http://codereview.chromium.org/10383263/diff/1/base/base.gyp
> File base/base.gyp (right):
> 
> http://codereview.chromium.org/10383263/diff/1/base/base.gyp#newcode688
> base/base.gyp:688: '--app_abi',
> Please merge with http://codereview.chromium.org/10399126/.
> This has moved into a template and we have more apk targets now. Not you only
> need to add this to the template.
I mean, you only need to modify the template and not individual gyp targets.

[yongsheng, 2012-05-26 04:46:54]

On 2012/05/25 20:39:05, nileshagrawal1 wrote:
> On 2012/05/25 20:38:22, nileshagrawal1 wrote:
> > http://codereview.chromium.org/10383263/diff/1/base/base.gyp
> > File base/base.gyp (right):
> > 
> > http://codereview.chromium.org/10383263/diff/1/base/base.gyp#newcode688
> > base/base.gyp:688: '--app_abi',
> > Please merge with http://codereview.chromium.org/10399126/.
> > This has moved into a template and we have more apk targets now. Not you
only
> > need to add this to the template.
> I mean, you only need to modify the template and not individual gyp targets.

Thanks all for your comments. Please review it for the patch set 2.

Besides, it seems "third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp"
doesn't use this template and thus it gets compile errors. I'll provide a patch
for that if it has not been fixed.

[yongsheng, 2012-05-26 05:32:18]

> Besides, it seems "third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp"
> doesn't use this template and thus it gets compile errors. I'll provide a
patch
> for that if it has not been fixed.
I don't find a wekbit bug to track this. So create a new one:
https://bugs.webkit.org/show_bug.cgi?id=87570

[nilesh, 2012-05-26 16:11:43]

On 2012/05/26 04:46:54, yongsheng.zhu wrote:
> On 2012/05/25 20:39:05, nileshagrawal1 wrote:
> > On 2012/05/25 20:38:22, nileshagrawal1 wrote:
> > > http://codereview.chromium.org/10383263/diff/1/base/base.gyp
> > > File base/base.gyp (right):
> > > 
> > > http://codereview.chromium.org/10383263/diff/1/base/base.gyp#newcode688
> > > base/base.gyp:688: '--app_abi',
> > > Please merge with http://codereview.chromium.org/10399126/.
> > > This has moved into a template and we have more apk targets now. Not you
> only
> > > need to add this to the template.
> > I mean, you only need to modify the template and not individual gyp targets.
> 
> Thanks all for your comments. Please review it for the patch set 2.
> 
> Besides, it seems "third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp"
> doesn't use this template and thus it gets compile errors. I'll provide a
patch
> for that if it has not been fixed.

You can temporarily make the new argument optional (and use a default value if
not specified) in the python script, to not break the build with your CL.

[yongsheng, 2012-05-27 05:52:22]

> You can temporarily make the new argument optional (and use a default value if
> not specified) in the python script, to not break the build with your CL.
done. compile can pass. Thanks.

[nilesh, 2012-05-29 05:26:20]

On 2012/05/27 05:52:22, yongsheng.zhu wrote:
> > You can temporarily make the new argument optional (and use a default value
if
> > not specified) in the python script, to not break the build with your CL.
> done. compile can pass. Thanks.

LGTM

[yongsheng, 2012-05-29 05:36:36]

On 2012/05/29 05:26:20, nileshagrawal1 wrote:
> On 2012/05/27 05:52:22, yongsheng.zhu wrote:
> > > You can temporarily make the new argument optional (and use a default
value
> if
> > > not specified) in the python script, to not break the build with your CL.
> > done. compile can pass. Thanks.
> 
> LGTM
Anyone who need review this? If no, I'll click the 'commit' button.

[commit-bot: I haz the power, 2012-05-29 07:27:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10383263/7003

[commit-bot: I haz the power, 2012-05-29 07:27:36]

Presubmit check for 10383263-7003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
yongsheng.zhu@intel.com is not in AUTHORS file. If you are a new contributor,
please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.5s to calculate.

[yongsheng, 2012-05-29 08:43:12]

On 2012/05/29 07:27:36, I haz the power (commit-bot) wrote:
> Presubmit check for 10383263-7003 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> --tbr was specified, skipping OWNERS check
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit Warnings **
> mailto:yongsheng.zhu@intel.com is not in AUTHORS file. If you are a new
contributor,
> please visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
> section
> If you are a chromite, verify the contributor signed the CLA.
> 
> Presubmit checks took 1.5s to calculate.
i've signed CLA. anyone who knows why?

[John Grabowski, 2012-05-29 20:50:51]

On 2012/05/29 08:43:12, yongsheng.zhu wrote:
> On 2012/05/29 07:27:36, I haz the power (commit-bot) wrote:
> > Presubmit check for 10383263-7003 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit Messages **
> > --tbr was specified, skipping OWNERS check
> > 
> > If this change requires manual test instructions to QA team, add
> > TEST=[instructions].
> > 
> > ** Presubmit Warnings **
> > mailto:yongsheng.zhu@intel.com is not in AUTHORS file. If you are a new
> contributor,
> > please visit
> > http://www.chromium.org/developers/contributing-code and read the "Legal"
> > section
> > If you are a chromite, verify the contributor signed the CLA.
> > 
> > Presubmit checks took 1.5s to calculate.
> i've signed CLA. anyone who knows why?

Send new CL with your name in src/AUTHORS
Land that one first

[yongsheng, 2012-05-30 01:38:15]

> Send new CL with your name in src/AUTHORS
> Land that one first
like others, add it in this patch together.

[commit-bot: I haz the power, 2012-05-30 01:39:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10383263/2007

[commit-bot: I haz the power, 2012-05-30 01:39:24]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force;
patching file AUTHORS
Hunk #1 FAILED at 177.
1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[commit-bot: I haz the power, 2012-05-30 01:45:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10383263/2008

[yongsheng, 2012-05-30 06:13:45]

Reviewers, 
Trybot results are ok. Not committed. I think it needs your 'LGTM'?

[commit-bot: I haz the power, 2012-05-30 07:43:25]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force;
patching file AUTHORS
Hunk #1 FAILED at 176.
1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[commit-bot: I haz the power, 2012-05-30 07:50:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10383263/18002

[commit-bot: I haz the power, 2012-05-30 09:27:14]

Change committed as 139512