Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: media/video/capture/video_capture.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_glue.h ('k') | media/video/video_decode_accelerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/video_capture.h
diff --git a/media/video/capture/video_capture.h b/media/video/capture/video_capture.h
index b825dff7592471bcde3f7586cc744a85609cb697..d0aef98f6f4a880700e035e6793daae57576d0e0 100644
--- a/media/video/capture/video_capture.h
+++ b/media/video/capture/video_capture.h
@@ -44,7 +44,7 @@ class MEDIA_EXPORT VideoCapture {
// TODO(wjia): add error codes.
// Callbacks provided by client for notification of events.
- class EventHandler {
+ class MEDIA_EXPORT EventHandler {
public:
// Notify client that video capture has been started.
virtual void OnStarted(VideoCapture* capture) = 0;
@@ -70,10 +70,12 @@ class MEDIA_EXPORT VideoCapture {
virtual void OnDeviceInfoReceived(
VideoCapture* capture,
const VideoCaptureParams& device_info) = 0;
+
+ protected:
+ virtual ~EventHandler() {}
};
VideoCapture() {}
- virtual ~VideoCapture() {}
// Request video capture to start capturing with |capability|.
// Also register |handler| with video capture for event handling.
@@ -93,6 +95,9 @@ class MEDIA_EXPORT VideoCapture {
virtual int CaptureHeight() = 0;
virtual int CaptureFrameRate() = 0;
+ protected:
+ virtual ~VideoCapture() {}
+
private:
DISALLOW_COPY_AND_ASSIGN(VideoCapture);
};
« no previous file with comments | « media/filters/ffmpeg_glue.h ('k') | media/video/video_decode_accelerator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698