Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: media/base/data_source.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_controller.h ('k') | media/base/demuxer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/data_source.h
diff --git a/media/base/data_source.h b/media/base/data_source.h
index f2a6a17ae73b6e5453ac85739ec0cd429cd5daff..78e4cd6faa09682d0025d5e267a8830353692944 100644
--- a/media/base/data_source.h
+++ b/media/base/data_source.h
@@ -14,8 +14,6 @@ namespace media {
class MEDIA_EXPORT DataSourceHost {
public:
- virtual ~DataSourceHost();
-
// Set the total size of the media file.
virtual void SetTotalBytes(int64 total_bytes) = 0;
@@ -27,6 +25,9 @@ class MEDIA_EXPORT DataSourceHost {
// Notify the host that time range [start,end] has been buffered.
virtual void AddBufferedTimeRange(base::TimeDelta start,
base::TimeDelta end) = 0;
+
+ protected:
+ virtual ~DataSourceHost();
};
class MEDIA_EXPORT DataSource : public base::RefCountedThreadSafe<DataSource> {
« no previous file with comments | « media/audio/audio_output_controller.h ('k') | media/base/demuxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698