Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: media/audio/audio_io.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_input_controller.h ('k') | media/audio/audio_output_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_io.h
diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h
index 84872148fe4a19ab0202260c84a4cc9409894b3f..50be7cd8025c58ae28fc63d97141b7b777d61022 100644
--- a/media/audio/audio_io.h
+++ b/media/audio/audio_io.h
@@ -56,8 +56,6 @@ class MEDIA_EXPORT AudioOutputStream {
// itself such as creating Windows or initializing COM.
class MEDIA_EXPORT AudioSourceCallback {
public:
- virtual ~AudioSourceCallback() {}
-
// Provide more data by filling |dest| up to |max_size| bytes. The provided
// buffer size is determined by the |samples_per_packet| specified in
// AudioParameters when the stream is created. The source will return
@@ -85,6 +83,9 @@ class MEDIA_EXPORT AudioOutputStream {
// plugins. In any case, data is usually immediately available,
// so there would be no delay.
virtual void WaitTillDataReady() {}
+
+ protected:
+ virtual ~AudioSourceCallback() {}
};
virtual ~AudioOutputStream() {}
@@ -119,8 +120,6 @@ class MEDIA_EXPORT AudioInputStream {
public:
class MEDIA_EXPORT AudioInputCallback {
public:
- virtual ~AudioInputCallback() {}
-
// Called by the audio recorder when a full packet of audio data is
// available. This is called from a special audio thread and the
// implementation should return as soon as possible.
@@ -138,6 +137,9 @@ class MEDIA_EXPORT AudioInputStream {
// recording will not continue. |code| is an error code that is platform
// specific.
virtual void OnError(AudioInputStream* stream, int code) = 0;
+
+ protected:
+ virtual ~AudioInputCallback() {}
};
virtual ~AudioInputStream() {}
« no previous file with comments | « media/audio/audio_input_controller.h ('k') | media/audio/audio_output_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698