Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: content/browser/download/download_item_impl.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/device_orientation/provider.h ('k') | content/browser/pepper_flash_settings_helper_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 1f72f5ef6e30b323a4b4a56b6f4a85814e0b7966..7975085adbc9de25c3a8cc1db86fcab782bc5698 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -37,7 +37,6 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
class CONTENT_EXPORT Delegate {
public:
Delegate();
- virtual ~Delegate();
// Used for catching use-after-free errors.
void Attach();
@@ -75,6 +74,9 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
// Assert consistent state for delgate object at various transitions.
virtual void AssertStateConsistent(DownloadItem* download) const = 0;
+ protected:
+ virtual ~Delegate();
+
private:
// For "Outlives attached DownloadItemImpl" invariant assertion.
int count_;
« no previous file with comments | « content/browser/device_orientation/provider.h ('k') | content/browser/pepper_flash_settings_helper_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698