Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5236)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | chrome/browser/policy/policy_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.cc
diff --git a/chrome/browser/nacl_host/nacl_process_host.cc b/chrome/browser/nacl_host/nacl_process_host.cc
index 161361e49410139097ecae3a7e7dbf40e498cd84..c1bd9293bee0dc9251ee6b5ae101a9dba964682e 100644
--- a/chrome/browser/nacl_host/nacl_process_host.cc
+++ b/chrome/browser/nacl_host/nacl_process_host.cc
@@ -330,8 +330,8 @@ scoped_ptr<CommandLine> NaClProcessHost::GetCommandForLaunchWithGdb(
return scoped_ptr<CommandLine>(cmd_line);
}
#elif defined(OS_LINUX)
-namespace {
-class NaClGdbWatchDelegate : public MessageLoopForIO::Watcher {
+class NaClProcessHost::NaClGdbWatchDelegate
+ : public MessageLoopForIO::Watcher {
public:
// fd_write_ is used by nacl-gdb via /proc/browser_PID/fd/fd_write_
NaClGdbWatchDelegate(int fd_read, int fd_write,
@@ -356,13 +356,13 @@ class NaClGdbWatchDelegate : public MessageLoopForIO::Watcher {
base::Closure reply_;
};
-void NaClGdbWatchDelegate::OnFileCanReadWithoutBlocking(int fd) {
+void NaClProcessHost::NaClGdbWatchDelegate::OnFileCanReadWithoutBlocking(
+ int fd) {
char buf;
if (HANDLE_EINTR(read(fd_read_, &buf, 1)) != 1 || buf != '\0')
LOG(ERROR) << "Failed to sync with nacl-gdb";
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, reply_);
}
-} // namespace
bool NaClProcessHost::LaunchNaClGdb(base::ProcessId pid) {
CommandLine::StringType nacl_gdb =
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | chrome/browser/policy/policy_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698