chrome/browser/extensions/api/downloads/downloads_api.h - Issue 10383262: RefCounted types should not have public destructors, delegate cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make win bot happy Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/downloads/downloads_api.h

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.h b/chrome/browser/extensions/api/downloads/downloads_api.h

index 372c80c77ed6fa51a8533fb01c7de30c4f9d97d9..1179f462976ea21109d1e9f52c4f854fd11224a1 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.h

+++ b/chrome/browser/extensions/api/downloads/downloads_api.h

@@ -66,6 +66,8 @@ class DownloadsFunctionInterface {

};

protected:

+ virtual ~DownloadsFunctionInterface() {}

// Return true if args_ is well-formed, otherwise set error_ and return false.

virtual bool ParseArgs() = 0;