Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: content/public/renderer/render_view.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_ 5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
6 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_ 6 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 class CONTENT_EXPORT RenderView : public IPC::Sender { 43 class CONTENT_EXPORT RenderView : public IPC::Sender {
44 public: 44 public:
45 // Returns the RenderView containing the given WebView. 45 // Returns the RenderView containing the given WebView.
46 static RenderView* FromWebView(WebKit::WebView* webview); 46 static RenderView* FromWebView(WebKit::WebView* webview);
47 47
48 // Visit all RenderViews with a live WebView (i.e., RenderViews that have 48 // Visit all RenderViews with a live WebView (i.e., RenderViews that have
49 // been closed but not yet destroyed are excluded). 49 // been closed but not yet destroyed are excluded).
50 static void ForEach(RenderViewVisitor* visitor); 50 static void ForEach(RenderViewVisitor* visitor);
51 51
52 virtual ~RenderView() {}
53
54 // Get the routing ID of the view. 52 // Get the routing ID of the view.
55 virtual int GetRoutingID() const = 0; 53 virtual int GetRoutingID() const = 0;
56 54
57 // Page IDs allow the browser to identify pages in each renderer process for 55 // Page IDs allow the browser to identify pages in each renderer process for
58 // keeping back/forward history in sync. 56 // keeping back/forward history in sync.
59 // Note that this is NOT updated for every main frame navigation, only for 57 // Note that this is NOT updated for every main frame navigation, only for
60 // "regular" navigations that go into session history. In particular, client 58 // "regular" navigations that go into session history. In particular, client
61 // redirects, like the page cycler uses (document.location.href="foo") do not 59 // redirects, like the page cycler uses (document.location.href="foo") do not
62 // count as regular navigations and do not increment the page id. 60 // count as regular navigations and do not increment the page id.
63 virtual int GetPageId() const = 0; 61 virtual int GetPageId() const = 0;
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // Displays a modal alert dialog containing the given message. Returns 119 // Displays a modal alert dialog containing the given message. Returns
122 // once the user dismisses the dialog. 120 // once the user dismisses the dialog.
123 virtual void RunModalAlertDialog(WebKit::WebFrame* frame, 121 virtual void RunModalAlertDialog(WebKit::WebFrame* frame,
124 const WebKit::WebString& message) = 0; 122 const WebKit::WebString& message) = 0;
125 123
126 // The client should handle the navigation externally. 124 // The client should handle the navigation externally.
127 virtual void LoadURLExternally( 125 virtual void LoadURLExternally(
128 WebKit::WebFrame* frame, 126 WebKit::WebFrame* frame,
129 const WebKit::WebURLRequest& request, 127 const WebKit::WebURLRequest& request,
130 WebKit::WebNavigationPolicy policy) = 0; 128 WebKit::WebNavigationPolicy policy) = 0;
129
130 protected:
131 virtual ~RenderView() {}
131 }; 132 };
132 133
133 } // namespace content 134 } // namespace content
134 135
135 #endif // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_ 136 #endif // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
OLDNEW
« no previous file with comments | « content/public/browser/worker_service_observer.h ('k') | content/renderer/media/scoped_loop_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698