Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: chrome/browser/extensions/webstore_install_helper.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 const std::string& id, 52 const std::string& id,
53 const SkBitmap& icon, 53 const SkBitmap& icon,
54 base::DictionaryValue* parsed_manifest) = 0; 54 base::DictionaryValue* parsed_manifest) = 0;
55 55
56 // Called to indicate a parse failure. The |result_code| parameter should 56 // Called to indicate a parse failure. The |result_code| parameter should
57 // indicate whether the problem was with the manifest or icon. 57 // indicate whether the problem was with the manifest or icon.
58 virtual void OnWebstoreParseFailure( 58 virtual void OnWebstoreParseFailure(
59 const std::string& id, 59 const std::string& id,
60 InstallHelperResultCode result_code, 60 InstallHelperResultCode result_code,
61 const std::string& error_message) = 0; 61 const std::string& error_message) = 0;
62
63 protected:
64 virtual ~Delegate() {}
62 }; 65 };
63 66
64 // Only one of |icon_data| (based64-encoded icon data) or |icon_url| can be 67 // Only one of |icon_data| (based64-encoded icon data) or |icon_url| can be
65 // specified, but it is legal for both to be empty. 68 // specified, but it is legal for both to be empty.
66 WebstoreInstallHelper(Delegate* delegate, 69 WebstoreInstallHelper(Delegate* delegate,
67 const std::string& id, 70 const std::string& id,
68 const std::string& manifest, 71 const std::string& manifest,
69 const std::string& icon_data, 72 const std::string& icon_data,
70 const GURL& icon_url, 73 const GURL& icon_url,
71 net::URLRequestContextGetter* context_getter); 74 net::URLRequestContextGetter* context_getter);
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 127
125 // A details string for keeping track of any errors. 128 // A details string for keeping track of any errors.
126 std::string error_; 129 std::string error_;
127 130
128 // A code to distinguish between an error with the icon, and an error with the 131 // A code to distinguish between an error with the icon, and an error with the
129 // manifest. 132 // manifest.
130 Delegate::InstallHelperResultCode parse_error_; 133 Delegate::InstallHelperResultCode parse_error_;
131 }; 134 };
132 135
133 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_ 136 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_pref_value_map.h ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698