RefCounted types should not have public destructors, delegate cleanup

chrome/browser/cancelable_request.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/cancelable_request.h"
 
 CancelableRequestProvider::CancelableRequestProvider()
     : next_handle_(1) {
 }
 
-CancelableRequestProvider::~CancelableRequestProvider() {
-  // There may be requests whose result callback has not been run yet. We need
-  // to cancel them otherwise they may try and call us back after we've been
-  // deleted, or do other bad things. This can occur on shutdown (or browser
-  // context destruction) when a request is scheduled, completed (but not
-  // dispatched), then the BrowserContext is deleted.
-  base::AutoLock lock(pending_request_lock_);
-  while (!pending_requests_.empty())
-    CancelRequestLocked(pending_requests_.begin());
-}
-
 CancelableRequestProvider::Handle CancelableRequestProvider::AddRequest(
     CancelableRequestBase* request,
     CancelableRequestConsumerBase* consumer) {
   Handle handle;
   {
     base::AutoLock lock(pending_request_lock_);
 
     handle = next_handle_;
     pending_requests_[next_handle_] = request;
     ++next_handle_;
     DCHECK(next_handle_)
         << "next_handle_ may have wrapped around to invalid state.";
   }
 
   consumer->OnRequestAdded(this, handle);
 
   request->Init(this, handle, consumer);
   return handle;
 }
 
 void CancelableRequestProvider::CancelRequest(Handle handle) {
   base::AutoLock lock(pending_request_lock_);
   CancelRequestLocked(pending_requests_.find(handle));
 }
 
+CancelableRequestProvider::~CancelableRequestProvider() {
+  // There may be requests whose result callback has not been run yet. We need
+  // to cancel them otherwise they may try and call us back after we've been
+  // deleted, or do other bad things. This can occur on shutdown (or browser
+  // context destruction) when a request is scheduled, completed (but not
+  // dispatched), then the BrowserContext is deleted.
+  base::AutoLock lock(pending_request_lock_);
+  while (!pending_requests_.empty())
+    CancelRequestLocked(pending_requests_.begin());
+}
+
 void CancelableRequestProvider::CancelRequestLocked(
     const CancelableRequestMap::iterator& item) {
   pending_request_lock_.AssertAcquired();
   if (item == pending_requests_.end()) {
     NOTREACHED() << "Trying to cancel an unknown request";
     return;
   }
 
   item->second->consumer()->OnRequestRemoved(this, item->first);
   item->second->set_canceled();
@@ skipping 74 matching lines @@
     // Execute the callback.
     forwarded_call.Run();
   }
 
   // Notify the provider that the request is complete. The provider will
   // notify the consumer for us. Note that it is possible for the callback to
   // cancel this request; we must check canceled again.
   if (!canceled_.IsSet())
     NotifyCompleted();
 }