Issue 10383254: At browser exit, wait for pending print jobs before starting shutdown. This is to avoid a nested me…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383254: At browser exit, wait for pending print jobs before starting shutdown. This is to avoid a nested me… (Closed)

Created:
8 years, 7 months ago by jam

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

At browser exit, wait for pending print jobs before starting shutdown. This is to avoid a nested message loop running other tasks that depend on objects which have already been destructed. Also, instead of waiting 2 minutes for a job, wait _up to_ 2 minutes. BUG=128824 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137996

Patch Set 1 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -28 lines)			Patch
M	chrome/browser/app_controller_mac.mm	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_job.h	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/print_job.cc	View	4 chunks	+15 lines, -9 lines	0 comments	Download
M	chrome/browser/printing/print_job_manager.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages