Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 10383249: touch: Make sure the correct radius values are used for touch events. (Closed)

Created:
8 years, 7 months ago by sadrul
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, jochen+watch-content_chromium.org, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

touch: Make sure the correct radius values are used for touch events. The device may not always report the radii values for a touch event. In such cases, instead of making up a default value, always use 0 so that it is easy to determine if the radius is the real radius reported by the device or not. Also, at the same time, make sure that the radius value sent to webkit follows the spec. Also fix the radii adjustment for device-scale-factor. BUG=128553 TEST=manually with test-pages Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138006

Patch Set 1 #

Total comments: 2

Patch Set 2 : non-zero-scale #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/aura/event.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/event.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M ui/base/x/events_x.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
8 years, 7 months ago (2012-05-18 19:42:00 UTC) #1
sky
http://codereview.chromium.org/10383249/diff/1/ui/aura/event.cc File ui/aura/event.cc (right): http://codereview.chromium.org/10383249/diff/1/ui/aura/event.cc#newcode288 ui/aura/event.cc:288: radius_x_ /= scale.x(); Are we sure these are non-zero?
8 years, 7 months ago (2012-05-18 19:57:37 UTC) #2
sadrul
http://codereview.chromium.org/10383249/diff/1/ui/aura/event.cc File ui/aura/event.cc (right): http://codereview.chromium.org/10383249/diff/1/ui/aura/event.cc#newcode288 ui/aura/event.cc:288: radius_x_ /= scale.x(); On 2012/05/18 19:57:37, sky wrote: > ...
8 years, 7 months ago (2012-05-18 20:07:32 UTC) #3
sky
8 years, 7 months ago (2012-05-18 21:53:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698