Issue 10383248: gdata: Add ability to fetch documents in a particular directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383248: gdata: Add ability to fetch documents in a particular directory (Closed)

Created:
8 years, 7 months ago by satorux1

Modified:
8 years, 7 months ago

Reviewers:
tbarzic

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Add ability to fetch documents in a particular directory This ability is needed to fix the stale thumbnail URLs issue. We need to get the updated thumbnail URLs in a directory, if we detect that the thumbnail URLs are stale. BUG=127697 TEST=the existing functionality should not change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137958

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix the build #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -15 lines)			Patch
M	chrome/browser/chromeos/extensions/external_filesystem_apitest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service_browsertest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		11 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operations.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operations.cc	View	1	4 chunks	+29 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_documents_service.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_documents_service.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tbarzic

8 years, 7 months ago (2012-05-18 19:59:02 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10383248/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_operations.cc (right):

https://chromiumcodereview.appspot.com/10383248/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_operations.cc:148: if (resource_id.empty())
s/resource_is/directory_resource_id/

but, you've probably noticed from trybot results :)

Expand Messages | Collapse Messages