Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/renderer/module_system.cc

Issue 10383242: Expose DumpException() in ModuleSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/module_system.cc
diff --git a/chrome/renderer/module_system.cc b/chrome/renderer/module_system.cc
index c0c0c8f5b1a290822f5a3850b49019c38f9369a7..f7ca6c4381ee8b56eec1e9bd31d20ab81db0cacc 100644
--- a/chrome/renderer/module_system.cc
+++ b/chrome/renderer/module_system.cc
@@ -14,14 +14,6 @@ const char* kModuleName = "module_name";
const char* kModuleField = "module_field";
const char* kModulesField = "modules";
-void DumpException(v8::Handle<v8::Message> message) {
- LOG(ERROR) << "["
- << *v8::String::Utf8Value(
- message->GetScriptResourceName()->ToString())
- << "(" << message->GetLineNumber() << ")] "
- << *v8::String::Utf8Value(message->Get());
-}
-
} // namespace
ModuleSystem::ModuleSystem(v8::Handle<v8::Context> context,
@@ -65,6 +57,15 @@ bool ModuleSystem::IsPresentInCurrentContext() {
return !global->GetHiddenValue(v8::String::New(kModuleSystem))->IsUndefined();
}
+// static
+void ModuleSystem::DumpException(v8::Handle<v8::Message> message) {
+ LOG(ERROR) << "["
+ << *v8::String::Utf8Value(
+ message->GetScriptResourceName()->ToString())
+ << "(" << message->GetLineNumber() << ")] "
+ << *v8::String::Utf8Value(message->Get());
+}
+
void ModuleSystem::Require(const std::string& module_name) {
v8::HandleScope handle_scope;
RequireForJsInner(v8::String::New(module_name.c_str()));

Powered by Google App Engine
This is Rietveld 408576698