Issue 10383242: Expose DumpException() in ModuleSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383242: Expose DumpException() in ModuleSystem. (Closed)

Created:
8 years, 7 months ago by koz (OOO until 15th September)

Modified:
8 years, 7 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Expose DumpException() in ModuleSystem. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137833

Patch Set 2 : respond to comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
M	chrome/renderer/module_system.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/module_system.cc	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/test/base/module_system_test.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm ModuleSystem seems like a bit of a strange place to expose that, but then ...

8 years, 7 months ago (2012-05-18 04:57:20 UTC) #2

koz (OOO until 15th September)

https://chromiumcodereview.appspot.com/10383242/diff/1/chrome/test/base/module_system_test.cc File chrome/test/base/module_system_test.cc (right): https://chromiumcodereview.appspot.com/10383242/diff/1/chrome/test/base/module_system_test.cc#newcode114 chrome/test/base/module_system_test.cc:114: } On 2012/05/18 04:57:20, kalman wrote: > nit: no ...

8 years, 7 months ago (2012-05-18 05:06:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10383242/5001

8 years, 7 months ago (2012-05-18 05:06:19 UTC) #4

Change committed as 137833

Expand Messages | Collapse Messages

Issue 10383242: Expose DumpException() in ModuleSystem. (Closed)

Description

Patch Set 1 #

Patch Set 2 : respond to comments #

Messages