chrome/common/extensions/extension_commands.h - Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_commands.h

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extension_commands_overlay.html ('K') | « chrome/chrome_browser.gypi ('k') | chrome/common/extensions/extension_commands_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_commands.h

===================================================================

--- chrome/common/extensions/extension_commands.h (revision 137495)

+++ chrome/common/extensions/extension_commands.h (working copy)

@@ -36,7 +36,7 @@

// Accessors:

const std::string& command_name() const { return command_name_; }

const ui::Accelerator& accelerator() const { return accelerator_; }

- const std::string& description() const { return description_; }

+ const string16& description() const { return description_; }

private:

ui::Accelerator ParseImpl(const std::string& shortcut,

@@ -45,7 +45,7 @@

string16* error);

std::string command_name_;

ui::Accelerator accelerator_;

- std::string description_;

+ string16 description_;

};

// A mapping of command name (std::string) to a command object.