Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.cc

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/page_action_image_view.cc
===================================================================
--- chrome/browser/ui/views/location_bar/page_action_image_view.cc (revision 138124)
+++ chrome/browser/ui/views/location_bar/page_action_image_view.cc (working copy)
@@ -65,10 +65,13 @@
set_accessibility_focusable(true);
- ExtensionCommandService* command_service =
- ExtensionCommandServiceFactory::GetForProfile(browser_->profile());
+ extensions::ExtensionCommandService* command_service =
+ extensions::ExtensionCommandServiceFactory::GetForProfile(
+ browser_->profile());
const extensions::Command* page_action_command =
- command_service->GetActivePageActionCommand(extension->id());
+ command_service->GetPageActionCommand(
+ extension->id(),
+ extensions::ExtensionCommandService::ACTIVE_ONLY);
if (page_action_command) {
keybinding_.reset(new ui::Accelerator(page_action_command->accelerator()));
owner_->GetFocusManager()->RegisterAccelerator(

Powered by Google App Engine
This is Rietveld 408576698