Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3396)

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (revision 138124)
+++ chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (working copy)
@@ -379,11 +379,12 @@
// Connect the accelerator for the browser action popup.
void ConnectBrowserActionPopupAccelerator() {
- ExtensionCommandService* command_service =
- ExtensionCommandServiceFactory::GetForProfile(
+ extensions::ExtensionCommandService* command_service =
+ extensions::ExtensionCommandServiceFactory::GetForProfile(
toolbar_->browser()->profile());
const extensions::Command* command =
- command_service->GetActiveBrowserActionCommand(extension_->id());
+ command_service->GetBrowserActionCommand(extension_->id(),
+ extensions::ExtensionCommandService::ACTIVE_ONLY);
if (command) {
// Found the browser action shortcut command, register it.
keybinding_.reset(new ui::AcceleratorGtk(

Powered by Google App Engine
This is Rietveld 408576698