chrome/browser/ui/webui/extensions/extensions_ui.cc - Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/commands/extension_command_service.h ('K') | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/common/extensions/extension_commands.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extensions_ui.cc

===================================================================

--- chrome/browser/ui/webui/extensions/extensions_ui.cc (revision 137495)

+++ chrome/browser/ui/webui/extensions/extensions_ui.cc (working copy)

@@ -7,9 +7,10 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"

+#include "chrome/browser/ui/webui/extensions/extension_commands_handler.h"

+#include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"

#include "chrome/browser/ui/webui/extensions/install_extension_handler.h"

#include "chrome/browser/ui/webui/extensions/pack_extension_handler.h"

-#include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"

#include "chrome/browser/ui/webui/shared_resources_data_source.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_ui.h"

@@ -24,6 +25,8 @@

source->set_use_json_js_format_v2();

source->set_json_path("strings.js");

source->add_resource_path("extensions.js", IDR_EXTENSIONS_JS);

+ source->add_resource_path("extension_command_list.js",

+ IDR_EXTENSION_COMMAND_LIST_JS);

source->add_resource_path("extension_list.js", IDR_EXTENSION_LIST_JS);

source->set_default_resource(IDR_EXTENSIONS_HTML);

return source;

@@ -45,6 +48,10 @@

pack_handler->GetLocalizedValues(source->localized_strings());

web_ui->AddMessageHandler(pack_handler);

+ ExtensionCommandsHandler* commands_handler = new ExtensionCommandsHandler();

+ commands_handler->GetLocalizedValues(source->localized_strings());

+ web_ui->AddMessageHandler(commands_handler);

InstallExtensionHandler* install_extension_handler =

new InstallExtensionHandler();

install_extension_handler->GetLocalizedValues(source->localized_strings());