Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3247)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/shared/js/load_time_data.js ('K') | « chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/location_bar_view_gtk.cc (revision 137495)
+++ chrome/browser/ui/gtk/location_bar_view_gtk.cc (working copy)
@@ -1690,7 +1690,8 @@
ExtensionCommandServiceFactory::GetForProfile(
owner_->browser()->profile());
const extensions::Command* command =
- command_service->GetActivePageActionCommand(extension->id());
+ command_service->GetPageActionCommand(
+ extension->id(), ExtensionCommandService::ACTIVE_ONLY);
if (command) {
// Found the browser action shortcut command, register it.
keybinding_.reset(new ui::AcceleratorGtk(
« chrome/browser/resources/shared/js/load_time_data.js ('K') | « chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698