Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4118)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
===================================================================
--- chrome/browser/resources/extensions/extensions.js (revision 137495)
+++ chrome/browser/resources/extensions/extensions.js (working copy)
@@ -5,6 +5,7 @@
<include src="../shared/js/cr/ui/drag_wrapper.js"></include>
<include src="../uber/uber_utils.js"></include>
<include src="extension_list.js"></include>
+<include src="extension_commands_overlay.js"></include>
Evan Stade 2012/05/18 21:08:26 alphabet?
Finnur 2012/05/18 22:02:04 Done.
<include src="pack_extension_overlay.js"></include>
// Used for observing function of the backend datasource for this page by
@@ -101,6 +102,16 @@
var packExtensionOverlay = extensions.PackExtensionOverlay.getInstance();
packExtensionOverlay.initializePage();
+ // Hook up the configure commands link to the overlay.
+ var link = document.querySelector('.extension-commands-config');
+ link.addEventListener('click',
+ this.handleExtensionCommandsConfig_.bind(this));
+
+ // Initialize the Commands overlay.
+ var extensionCommandsOverlay =
+ extensions.ExtensionCommandsOverlay.getInstance();
+ extensionCommandsOverlay.initializePage();
+
cr.ui.overlay.setupOverlay($('dropTargetOverlay'));
},
@@ -129,6 +140,17 @@
},
/**
+ * Handles the Configure (Extension) Commands link.
+ * @param {Event} e Change event.
+ * @private
+ */
+ handleExtensionCommandsConfig_: function(e) {
+ ExtensionSettings.showOverlay($('extensionCommandsOverlay'));
+ chrome.send('coreOptionsUserMetricsAction',
+ ['Options_ExtensionCommands']);
+ },
+
+ /**
* Handles the Update Extension Now button.
* @param {Event} e Change event.
* @private

Powered by Google App Engine
This is Rietveld 408576698