Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

Issue 10383240: This adds a webui overlay on the extensions page for showing what Extension keybindings are active.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.h" 5 #include "chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.h"
6 6
7 #include "chrome/browser/extensions/api/commands/extension_command_service.h" 7 #include "chrome/browser/extensions/api/commands/extension_command_service.h"
8 #include "chrome/browser/extensions/api/commands/extension_command_service_facto ry.h" 8 #include "chrome/browser/extensions/api/commands/extension_command_service_facto ry.h"
9 #include "chrome/browser/extensions/extension_browser_event_router.h" 9 #include "chrome/browser/extensions/extension_browser_event_router.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
(...skipping 26 matching lines...) Expand all
37 const GdkEventKey* event) const { 37 const GdkEventKey* event) const {
38 ui::AcceleratorGtk accelerator(ui::WindowsKeyCodeForGdkKeyCode(event->keyval), 38 ui::AcceleratorGtk accelerator(ui::WindowsKeyCodeForGdkKeyCode(event->keyval),
39 event->state & GDK_SHIFT_MASK, 39 event->state & GDK_SHIFT_MASK,
40 event->state & GDK_CONTROL_MASK, 40 event->state & GDK_CONTROL_MASK,
41 event->state & GDK_MOD1_MASK); 41 event->state & GDK_MOD1_MASK);
42 return event_targets_.find(accelerator) != event_targets_.end(); 42 return event_targets_.find(accelerator) != event_targets_.end();
43 } 43 }
44 44
45 void ExtensionKeybindingRegistryGtk::AddExtensionKeybinding( 45 void ExtensionKeybindingRegistryGtk::AddExtensionKeybinding(
46 const extensions::Extension* extension) { 46 const extensions::Extension* extension) {
47 ExtensionCommandService* command_service = 47 extensions::ExtensionCommandService* command_service =
48 ExtensionCommandServiceFactory::GetForProfile(profile_); 48 extensions::ExtensionCommandServiceFactory::GetForProfile(profile_);
49 const extensions::CommandMap& commands = 49 const extensions::CommandMap& commands =
50 command_service->GetActiveNamedCommands(extension->id()); 50 command_service->GetNamedCommands(
51 extension->id(),
52 extensions::ExtensionCommandService::ACTIVE_ONLY);
51 extensions::CommandMap::const_iterator iter = commands.begin(); 53 extensions::CommandMap::const_iterator iter = commands.begin();
52 for (; iter != commands.end(); ++iter) { 54 for (; iter != commands.end(); ++iter) {
53 ui::AcceleratorGtk accelerator(iter->second.accelerator().key_code(), 55 ui::AcceleratorGtk accelerator(iter->second.accelerator().key_code(),
54 iter->second.accelerator().IsShiftDown(), 56 iter->second.accelerator().IsShiftDown(),
55 iter->second.accelerator().IsCtrlDown(), 57 iter->second.accelerator().IsCtrlDown(),
56 iter->second.accelerator().IsAltDown()); 58 iter->second.accelerator().IsAltDown());
57 event_targets_[accelerator] = 59 event_targets_[accelerator] =
58 std::make_pair(extension->id(), iter->second.command_name()); 60 std::make_pair(extension->id(), iter->second.command_name());
59 61
60 if (!accel_group_) { 62 if (!accel_group_) {
61 accel_group_ = gtk_accel_group_new(); 63 accel_group_ = gtk_accel_group_new();
62 gtk_window_add_accel_group(window_, accel_group_); 64 gtk_window_add_accel_group(window_, accel_group_);
63 } 65 }
64 66
65 gtk_accel_group_connect( 67 gtk_accel_group_connect(
66 accel_group_, 68 accel_group_,
67 accelerator.GetGdkKeyCode(), 69 accelerator.GetGdkKeyCode(),
68 accelerator.gdk_modifier_type(), 70 accelerator.gdk_modifier_type(),
69 GtkAccelFlags(0), 71 GtkAccelFlags(0),
70 g_cclosure_new(G_CALLBACK(OnGtkAcceleratorThunk), this, NULL)); 72 g_cclosure_new(G_CALLBACK(OnGtkAcceleratorThunk), this, NULL));
71 } 73 }
72 74
73 // Unlike on Windows, we need to explicitly add the browser action and page 75 // Unlike on Windows, we need to explicitly add the browser action and page
74 // action to the event_targets_, even though we don't register them as 76 // action to the event_targets_, even though we don't register them as
75 // handlers. See http://crbug.com/124873. 77 // handlers. See http://crbug.com/124873.
76 const extensions::Command* browser_action = 78 const extensions::Command* browser_action =
77 command_service->GetActiveBrowserActionCommand(extension->id()); 79 command_service->GetBrowserActionCommand(
80 extension->id(),
81 extensions::ExtensionCommandService::ACTIVE_ONLY);
78 if (browser_action) { 82 if (browser_action) {
79 ui::AcceleratorGtk accelerator(browser_action->accelerator().key_code(), 83 ui::AcceleratorGtk accelerator(browser_action->accelerator().key_code(),
80 browser_action->accelerator().IsShiftDown(), 84 browser_action->accelerator().IsShiftDown(),
81 browser_action->accelerator().IsCtrlDown(), 85 browser_action->accelerator().IsCtrlDown(),
82 browser_action->accelerator().IsAltDown()); 86 browser_action->accelerator().IsAltDown());
83 event_targets_[accelerator] = 87 event_targets_[accelerator] =
84 std::make_pair(extension->id(), browser_action->command_name()); 88 std::make_pair(extension->id(), browser_action->command_name());
85 } 89 }
86 90
87 const extensions::Command* page_action = 91 const extensions::Command* page_action =
88 command_service->GetActivePageActionCommand(extension->id()); 92 command_service->GetPageActionCommand(
93 extension->id(),
94 extensions::ExtensionCommandService::ACTIVE_ONLY);
89 if (page_action) { 95 if (page_action) {
90 ui::AcceleratorGtk accelerator(page_action->accelerator().key_code(), 96 ui::AcceleratorGtk accelerator(page_action->accelerator().key_code(),
91 page_action->accelerator().IsShiftDown(), 97 page_action->accelerator().IsShiftDown(),
92 page_action->accelerator().IsCtrlDown(), 98 page_action->accelerator().IsCtrlDown(),
93 page_action->accelerator().IsAltDown()); 99 page_action->accelerator().IsAltDown());
94 event_targets_[accelerator] = 100 event_targets_[accelerator] =
95 std::make_pair(extension->id(), page_action->command_name()); 101 std::make_pair(extension->id(), page_action->command_name());
96 } 102 }
97 } 103 }
98 104
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 if (it == event_targets_.end()) { 139 if (it == event_targets_.end()) {
134 NOTREACHED(); // Shouldn't get this event for something not registered. 140 NOTREACHED(); // Shouldn't get this event for something not registered.
135 return FALSE; 141 return FALSE;
136 } 142 }
137 143
138 service->browser_event_router()->CommandExecuted( 144 service->browser_event_router()->CommandExecuted(
139 profile_, it->second.first, it->second.second); 145 profile_, it->second.first, it->second.second);
140 146
141 return TRUE; 147 return TRUE;
142 } 148 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc ('k') | chrome/browser/ui/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698