This adds a webui overlay on the extensions page for showing what Extension keybindings are active.…

chrome/browser/resources/shared/js/load_time_data.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This file defines a singleton which provides access to all data
  * that is available as soon as the page's resources are loaded (before DOM
  * content has finished loading). This data includes both localized strings and
  * any data that is important to have ready from a very early stage (e.g. things
  * that must be displayed right away).
@@ skipping 24 matching lines @@
       return id in this.data_;
     },
 
     /**
      * Fetches a value, expecting that it exists.
      * @param {string} id The key that identifies the desired value.
      * @return {*} The corresponding value.
      */
     getValue: function(id) {
       expect(this.data_, 'No data. Did you remember to include strings.js?');
+      // If your value is not found here, inspect the contents of this.data_.
+      // If you find none of your values there, then make sure that
+      // GetLocalizedValues() in your handler class (in C++) is called.

[Evan Stade, 2012/05/18 21:08:26]

this comment is inaccurate, GetLocalizedValues() does not exist for all
WebUIMessageHandler classes. I don't think it's worth including --- this isn't
where I would expect most people to look for documentation.

[Finnur, 2012/05/18 22:02:04]

Having gone through the exercise of trying to figure out why the messages aren't
showing up properly this is where the dead-end was reached. It wasn't obvious
where to go from here in the C++ code. 

Is there any generic comment we can use here instead (to point people in the
right direction) or should we just remove it?

On 2012/05/18 21:08:26, Evan Stade wrote:

[Evan Stade, 2012/05/18 22:14:23]

not obvious where to go in the C++ code? You added the C++ code which attempted
but failed to set new strings, so I would have thought it pretty clear you have
to go there to see why it wasn't working.

On 2012/05/18 22:02:04, Finnur wrote:

[Finnur, 2012/05/18 22:27:01]

I added GetLocalizedValues() but overlooked the fact that you have to explicitly
call it. Then it looks like the C++ code is correct, but it isn't actually doing
anything so you blame the .js side of things. Anyway, I was just trying to help
the next guy. I'll just remove the comment. 

On 2012/05/18 22:14:23, Evan Stade wrote:

       var value = this.data_[id];
       expect(typeof value != 'undefined', 'Could not find value for ' + id);
       return value;
     },
 
     /**
      * As above, but also makes sure that the value is a string.
      * @param {string} id The key that identifies the desired string.
      * @return {string} The corresponding string value.
      */
@@ skipping 62 matching lines @@
    * @param {string} type The type we expect |value| to be.
    */
   function expectIsType(id, value, type) {
     expect(typeof value == type, '[' + value + '] (' + id +
                                  ') is not a ' + type);
   }
 
   expect(!loadTimeData, 'should only include this file once');
   loadTimeData = new LoadTimeData;
 })();