ui/views/widget/widget.cc - Issue 10383234: views: Do not set capture on a widget if it cannot be activated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget.cc

Issue 10383234: views: Do not set capture on a widget if it cannot be activated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: self-nit Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/widget.cc

diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc

index ef990aabdc5b4435456072a093ed0c6d0220ec27..e5f30724ee2144c590d562f78e45a3f4fb91dbd2 100644

--- a/ui/views/widget/widget.cc

+++ b/ui/views/widget/widget.cc

@@ -518,7 +518,7 @@ void Widget::Show() {

native_widget_->Show();

}

- if (close_on_deactivate_) {

+ if (CanActivate() && close_on_deactivate_) {

// Set mouse capture on timeout in case this is called from a

// mouse pressed handler.

MessageLoopForUI::current()->PostTask(FROM_HERE, base::Bind(

« no previous file with comments | « ash/system/tray/system_tray_widget_delegate.cc ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »