Issue 10383234: views: Do not set capture on a widget if it cannot be activated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383234: views: Do not set capture on a widget if it cannot be activated. (Closed)

Created:
8 years, 7 months ago by sadrul

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

views: Do not set capture on a widget if it cannot be activated. BUG=128566 TEST=views_unittests:WidgetTest.ActivationCapture Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137736

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -2 lines)			Patch
M	ash/system/network/tray_network.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/tray/system_tray_widget_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/widget.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sadrul

The change in tray_network alone is sufficient to fix the bug. But it felt like ...

8 years, 7 months ago (2012-05-17 19:49:34 UTC) #1

LGTM