Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 10383232: Remove all the unused automation IPCs. (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
Reviewers:
cmp, Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Remove all the unused automation IPCs. BUG=121574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -562 lines) Patch
M chrome/common/automation_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/automation_messages_internal.h View 31 chunks +0 lines, -561 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
I'll update the reference builds once the builders are finished.
8 years, 7 months ago (2012-05-17 16:20:33 UTC) #1
Elliot Glaysher
lgtm
8 years, 7 months ago (2012-05-17 16:30:05 UTC) #2
cmp
It seems unnecessary to break compatibility when the change is just removing lines. I think ...
8 years, 7 months ago (2012-05-17 18:04:31 UTC) #3
jam
I agree that normally no need to do this, when one or two IPCs aren't ...
8 years, 7 months ago (2012-05-17 18:10:29 UTC) #4
cmp
8 years, 7 months ago (2012-05-17 18:25:34 UTC) #5
What is the cost of putting off removing unused IPC messages in the reference
build?  AFAIK there is no cost, so if there is, then that could change my
opinion of what we do here.

The cost to updating the reference build is ensuring that the reference builds
are correctly updated, that tests on the trunk and the branch continue to work
after the update, and that perf expectations are all updated correctly and
working once more.  Selecting a good time to update the reference build is also
important, since now the performance of the reference build will change in our
perf tests.  Some tests may get more or less flaky, for example.  Some tests may
start to show the reference build's perf has greater variance in its results.

Powered by Google App Engine
This is Rietveld 408576698