Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 10383229: Cleanup: Remove unneeded scoped_ptr.h includes from net. (Closed)

Created:
8 years, 7 months ago by Lei Zhang
Modified:
8 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

Cleanup: Remove unneeded scoped_ptr.h includes from net. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137636

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -35 lines) Patch
M chrome_frame/urlmon_upload_data_stream.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/android/network_change_notifier_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/crl_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/host_resolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/multi_threaded_cert_verifier.h View 2 chunks +4 lines, -5 lines 0 comments Download
M net/base/upload_data_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/curvecp/packetizer.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/disk_cache/stats.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/dns/dns_config_service_posix.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_session.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/disk_cache_based_ssl_host_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_pipelined_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_decider.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/proxy/sync_host_resolver_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/server/web_socket.h View 3 chunks +2 lines, -3 lines 0 comments Download
M net/socket/ssl_host_info.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_throttler_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
8 years, 7 months ago (2012-05-17 01:19:37 UTC) #1
Ryan Sleevi
lgtm https://chromiumcodereview.appspot.com/10383229/diff/1/net/base/multi_threaded_cert_verifier.h File net/base/multi_threaded_cert_verifier.h (right): https://chromiumcodereview.appspot.com/10383229/diff/1/net/base/multi_threaded_cert_verifier.h#newcode35 net/base/multi_threaded_cert_verifier.h:35: NON_EXPORTED_BASE(public base::NonThreadSafe), Probably should shuffle these so the ...
8 years, 7 months ago (2012-05-17 01:25:37 UTC) #2
Lei Zhang
https://chromiumcodereview.appspot.com/10383229/diff/1/net/base/multi_threaded_cert_verifier.h File net/base/multi_threaded_cert_verifier.h (right): https://chromiumcodereview.appspot.com/10383229/diff/1/net/base/multi_threaded_cert_verifier.h#newcode35 net/base/multi_threaded_cert_verifier.h:35: NON_EXPORTED_BASE(public base::NonThreadSafe), On 2012/05/17 01:25:37, Ryan Sleevi wrote: > ...
8 years, 7 months ago (2012-05-17 01:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10383229/12002
8 years, 7 months ago (2012-05-17 05:19:19 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 06:40:42 UTC) #5
Change committed as 137636

Powered by Google App Engine
This is Rietveld 408576698