Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome/browser/resources/help/help.js

Issue 10383228: Revert 137554 - convert help page to loadTimeData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/help/help.html ('k') | chrome/browser/ui/webui/help/help_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/help/help.js
===================================================================
--- chrome/browser/resources/help/help.js (revision 137579)
+++ chrome/browser/resources/help/help.js (working copy)
@@ -5,6 +5,8 @@
<include src="../uber/uber_utils.js">
cr.define('help', function() {
+ var localStrings = new LocalStrings();
+
/**
* Encapsulated handling of the help page.
*/
@@ -22,18 +24,17 @@
uber.onContentFrameLoaded();
// Set the title.
- var title = loadTimeData.getString('helpTitle');
+ var title = localStrings.getString('helpTitle');
uber.invokeMethodOnParent('setTitle', {title: title});
- $('product-license').innerHTML = loadTimeData.getString('productLicense');
- if (cr.isChromeOS) {
+ $('product-license').innerHTML = localStrings.getString('productLicense');
+ if (cr.isChromeOS)
$('product-os-license').innerHTML =
- loadTimeData.getString('productOsLicense');
- }
+ localStrings.getString('productOsLicense');
var productTOS = $('product-tos');
if (productTOS)
- productTOS.innerHTML = loadTimeData.getString('productTOS');
+ productTOS.innerHTML = localStrings.getString('productTOS');
$('get-help').onclick = chrome.send.bind(chrome, 'openHelpPage');
$('report-issue').onclick =
@@ -70,8 +71,8 @@
moreInfo.style.height = visible ? '' : moreInfo.scrollHeight + 'px';
moreInfo.addEventListener('webkitTransitionEnd', function(event) {
$('more-info-expander').textContent = visible ?
- loadTimeData.getString('showMoreInfo') :
- loadTimeData.getString('hideMoreInfo');
+ localStrings.getString('showMoreInfo') :
+ localStrings.getString('hideMoreInfo');
});
},
@@ -98,17 +99,17 @@
if (status == 'checking') {
this.setUpdateImage_('working');
$('update-status').innerHTML =
- loadTimeData.getString('updateCheckStarted');
+ localStrings.getString('updateCheckStarted');
} else if (status == 'updating') {
this.setUpdateImage_('working');
- $('update-status').innerHTML = loadTimeData.getString('updating');
+ $('update-status').innerHTML = localStrings.getString('updating');
} else if (status == 'nearly_updated') {
this.setUpdateImage_('up-to-date');
$('update-status').innerHTML =
- loadTimeData.getString('updateAlmostDone');
+ localStrings.getString('updateAlmostDone');
} else if (status == 'updated') {
this.setUpdateImage_('up-to-date');
- $('update-status').innerHTML = loadTimeData.getString('upToDate');
+ $('update-status').innerHTML = localStrings.getString('upToDate');
} else if (status == 'failed') {
this.setUpdateImage_('failed');
$('update-status').innerHTML = message;
« no previous file with comments | « chrome/browser/resources/help/help.html ('k') | chrome/browser/ui/webui/help/help_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698